Fix make consul-enterprise-version to work for both dev and prod images#2488
Closed
Fix make consul-enterprise-version to work for both dev and prod images#2488
make consul-enterprise-version to work for both dev and prod images#2488Conversation
t-eckert
requested review from
a team,
erichaberkorn and
zalimeni
and removed request for
a team
t-eckert
added
pr/no-changelog
Contributor
Author
|
This change does not need to be backported to branches other than |
t-eckert
added
backport/1.2.x
zalimeni
approved these changes
Jul 5, 2023
Member
zalimeni
left a comment
zalimeni
left a comment
There was a problem hiding this comment.
Approving since this is status-quo following the last release.
Curious whether in the future we could look at making the dev + prod tagging consistent so this sort of workaround isn't necessary - but happy to not block on that now.
Contributor
|
This has been covered by #2756 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
makecommand to set the enterprise Consul image when running unit tests. For development images the delta from non-enterprise images to enterprise images is to just change the image name fromconsultoconsul-enterprise. In prod, you must also add a-entto the end of the image tag. This change takes that difference into account so that we can use themakecommand when releasing to production.