-
Notifications
You must be signed in to change notification settings - Fork 339
Adding support for Enterprise and other improvement on the Customizing Vault Version for WanFed Test #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Adding support for Enterprise and other improvement on the Customizing Vault Version for WanFed Test #2481
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
073a1c8
Adding support for Enterprise and other improvement on the Customizin…
20sr20 cb59ab3
Removing the changes in vault_namespaces_test.go
20sr20 05eda79
Introducing new flag no-cleanup
20sr20 c96b7e0
Removed "go 1.20" from go.work file
20sr20 9cb0694
Merge branch 'main' into vault-consul-compatibility-test-v2
20sr20 d6e9079
cfg.USEKind check is added back
20sr20 6a7c048
Merge branch 'vault-consul-compatibility-test-v2' of https://github.c…
20sr20 5fc6aaa
Removed previousy added "Test Duration" flag
20sr20 4d19e04
Merge branch 'main' into vault-consul-compatibility-test-v2
20sr20 d3538e0
Some changes
20sr20 3e1551f
Merge branch 'vault-consul-compatibility-test-v2' of https://github.c…
20sr20 9b372a5
Some changes
20sr20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,9 @@ package vault | |
| import ( | ||
| "context" | ||
| "fmt" | ||
| "strconv" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/hashicorp/consul-k8s/acceptance/framework/config" | ||
| "github.com/hashicorp/consul-k8s/acceptance/framework/consul" | ||
|
|
@@ -31,9 +33,9 @@ import ( | |
| // in the secondary that will treat the Vault server in the primary as an external server. | ||
| func TestVault_WANFederationViaGateways(t *testing.T) { | ||
| cfg := suite.Config() | ||
| if cfg.UseKind { | ||
| t.Skipf("Skipping this test because it's currently flaky on kind") | ||
| } | ||
| //if cfg.UseKind { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reminder: add back?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added back |
||
| // t.Skipf("Skipping this test because it's currently flaky on kind") | ||
| //} | ||
| if !cfg.EnableMultiCluster { | ||
| t.Skipf("skipping this test because -enable-multi-cluster is not set") | ||
| } | ||
|
|
@@ -491,11 +493,13 @@ func TestVault_WANFederationViaGateways(t *testing.T) { | |
| logger.Log(t, "creating proxy-defaults config") | ||
| kustomizeDir := "../fixtures/bases/mesh-gateway" | ||
| k8s.KubectlApplyK(t, primaryCtx.KubectlOptions(t), kustomizeDir) | ||
|
|
||
| helpers.Cleanup(t, cfg.NoCleanupOnFailure, func() { | ||
| k8s.KubectlDeleteK(t, primaryCtx.KubectlOptions(t), kustomizeDir) | ||
| }) | ||
|
|
||
| // Check that we can connect services over the mesh gateways. | ||
|
|
||
| logger.Log(t, "creating static-server in dc2") | ||
| k8s.DeployKustomize(t, secondaryCtx.KubectlOptions(t), cfg.NoCleanupOnFailure, cfg.DebugDirectory, "../fixtures/cases/static-server-inject") | ||
|
|
||
|
|
@@ -517,6 +521,19 @@ func TestVault_WANFederationViaGateways(t *testing.T) { | |
|
|
||
| logger.Log(t, "checking that connection is successful") | ||
| k8s.CheckStaticServerConnectionSuccessful(t, primaryCtx.KubectlOptions(t), StaticClientName, "http://localhost:1234") | ||
|
|
||
| if cfg.NoCleanupWanFed { | ||
| //time.Sleep(1800 * time.Second) | ||
| intVar, err := strconv.Atoi(cfg.TestDuration) | ||
|
20sr20 marked this conversation as resolved.
Outdated
|
||
|
|
||
| if err != nil { | ||
| logger.Log(t, "Couldn't convert string to int") | ||
|
|
||
| } | ||
| time.Sleep(time.Duration(intVar) * time.Hour) | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| // vaultAddress returns Vault's server URL depending on test configuration. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| go 1.20 | ||
|
20sr20 marked this conversation as resolved.
Outdated
|
||
|
|
||
| use ( | ||
| ./acceptance | ||
| ./charts | ||
| ./cli | ||
| ./control-plane | ||
| ./control-plane/cni | ||
| ./hack/aws-acceptance-test-cleanup | ||
| ./hack/copy-crds-to-chart | ||
| ./hack/helm-reference-gen | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.