Backport of Adding support for weighted k8s service into release/1.2.x#2402
Merged
thisisnotashwin merged 10 commits intorelease/1.2.xfrom Jun 21, 2023
Conversation
added 9 commits
June 7, 2023 04:33
hc-github-team-consul-core
force-pushed
the
backport/srahul3/support-for-weighted-k8s-service/implicitly-sunny-sparrow
branch
from
f4ab9a8 to
1eb2e49
Compare
thisisnotashwin
force-pushed
the
backport/srahul3/support-for-weighted-k8s-service/implicitly-sunny-sparrow
branch
from
1eb2e49 to
4c9478f
Compare
thisisnotashwin
approved these changes
Jun 21, 2023
thisisnotashwin
deleted the
backport/srahul3/support-for-weighted-k8s-service/implicitly-sunny-sparrow
branch
thisisnotashwin
added a commit
that referenced
this pull request
Jun 21, 2023
#2402) * backport of commit fdef617 * backport of commit 7d47c00 * backport of commit 552c0e7 * backport of commit 14fa790 * backport of commit 9f396c3 * backport of commit 3320b62 * backport of commit dc3e24e * backport of commit 3dad9a0 * backport of commit 95b3f7c * backport of commit fa54600 --------- Co-authored-by: srahul3 <rahulsharma@hashicorp.com> Co-authored-by: Ashwin Venkatesh <ashwin.what@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2293 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
🚨
The person who merged in the original PR is:
@srahul3
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Context
According to the documentation Consul supports setting weights for services . Unfortunately currently there is no way of doing that when using consul-k8s, as there is no annotation that can control that + there is no easy way of doing it via Consul API and it looks like the changes will be anyway overwritten.
Related link: https://hashicorp.atlassian.net/browse/NET-4266
Changes proposed in this PR:
consul.hashicorp.com/service-weight: <number>is read and then the weight is divided among underlying ingress/ips. The calculated weight is persisted as passing weight inconsulapi.CatalogRegistrationHow I've tested this PR:
Added the Junit test for different scenarios
How I expect reviewers to test this PR:
Checklist:
Overview of commits