api-gateway: e2e gatewayclassconfig test #2344
Conversation
sarahalsmiller
added
pr/no-changelog
sarahalsmiller
changed the title
sarahalsmiller
force-pushed
the
NET-4270-GatewayClassConfig-based-End-to-End-tests
branch
from
6a39098 to
94315f3
Compare
| labels := common.LabelsForGateway(gateway) | ||
| err = k8client.List(context.Background(), &podList, client.InNamespace(namespace), client.MatchingLabels(labels)) | ||
| require.NoError(r, err) | ||
| require.EqualValues(r, *wantNumber, *deployment.Spec.Replicas) |
There was a problem hiding this comment.
Is the intention for this to assert the length of podList instead of a value on the Deployment that was fetched in the stanza before this one?
| "testing" | ||
| ) | ||
|
|
||
| func TestAPIGateway_GatewayClassConfigEndToEnd(t *testing.T) { |
There was a problem hiding this comment.
Would you please add a comment here explaining what this test covers? I understand the "End-to-end" phrasing comes from the Jira ticket, but I think that is a given when we are dealing with acceptance tests.
You could shorten it to TestAPIGateway_GatewayClassConfig and just talk about the scaling parameters and whatnot in a comment.
|
There are a few extra blank lines that would be nice to tidy up. |
t-eckert
left a comment
t-eckert
left a comment
There was a problem hiding this comment.
Great work! Really put my laptop through its paces when I ran it locally.
sarahalsmiller
force-pushed
the
NET-4270-GatewayClassConfig-based-End-to-End-tests
branch
from
3fa44b5 to
83af2c1
Compare
|
This acceptance test work was pulled into #2377, as that PR contains a fix for a bug that this test uncovered. Closing. |
github-actions
bot
deleted the
NET-4270-GatewayClassConfig-based-End-to-End-tests
branch
3 participants
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: