Backport of Ensure Reconciliation Stops into release/1.2.x#2332
Closed
hc-github-team-consul-core wants to merge 6 commits intorelease/1.2.xfrom
Closed
Backport of Ensure Reconciliation Stops into release/1.2.x#2332hc-github-team-consul-core wants to merge 6 commits intorelease/1.2.xfrom
hc-github-team-consul-core wants to merge 6 commits intorelease/1.2.xfrom
Conversation
hc-github-team-consul-core
force-pushed
the
backport/NET-4231-halting-problem/strictly-expert-skunk
branch
from
e1d492f to
b670436
Compare
jm96441n
approved these changes
Jun 9, 2023
Contributor
|
@jm96441n @nathancoleman Given the proximity to the RC release, I think we should hold off on merging this/fix it in main first. We can merge it into |
Member
|
Closing this backport. The original PR is being reverted out of |
auto-merge was automatically disabled
June 12, 2023 16:35
Pull request was closed
nathancoleman
deleted the
backport/NET-4231-halting-problem/strictly-expert-skunk
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2305 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
How I've tested this PR:
Wrote the test/ran the test
How I expect reviewers to test this PR:
read the code/run the test
Checklist:
Overview of commits