Backport of [API Gateway] fix dangling service registrations into release/1.2.x#2323
Merged
hc-github-team-consul-core merged 2 commits intorelease/1.2.xfrom Jun 9, 2023
Conversation
added 2 commits
June 9, 2023 05:58
hc-github-team-consul-core
force-pushed
the
backport/net-4408/fix-dangling-service-registrations/officially-fit-firefly
branch
from
b68ec63 to
1761c5b
Compare
andrewstucki
approved these changes
Jun 9, 2023
hc-github-team-consul-core
deleted the
backport/net-4408/fix-dangling-service-registrations/officially-fit-firefly
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2321 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
This bypasses the cache on gateway deletion to make sure we have dropped any registered services in Consul even if we haven't been informed about them via the cache yet. We had a race condition where if a pod was just registered with Consul we might not know about it if the gateway was deleted right away. I noticed this scenario when running conformance tests when we were leaving around services that were no longer there.
How I've tested this PR:
Ran conformance tests and made sure that quickly deleted gateways are cleaned up in Consul
Checklist:
Overview of commits