Backport of Fix bug on service intention CRDs causing missed updates into release/1.0.x#2220
Merged
hc-github-team-consul-core merged 1 commit intorelease/1.0.xfrom Jun 6, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/fix-service-intention-crd-bug/kindly-in-starfish
branch
from
d8250a9 to
1d4eea4
Compare
erichaberkorn
force-pushed
the
backport/fix-service-intention-crd-bug/kindly-in-starfish
branch
from
1d4eea4 to
925cb23
Compare
Contributor
|
@erichaberkorn Should this be merged? |
erichaberkorn
force-pushed
the
backport/fix-service-intention-crd-bug/kindly-in-starfish
branch
from
925cb23 to
0eef689
Compare
erichaberkorn
approved these changes
Jun 6, 2023
hc-github-team-consul-core
deleted the
backport/fix-service-intention-crd-bug/kindly-in-starfish
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2194 to be assessed for backporting due to the inclusion of the label backport/1.0.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
This code was originally added here to avoid modifying all intentions when upgrading from Consul pre-1.12 to 1.12+. Consul-K8s 1.0.x is compatible with Consul 1.14.x and Consul-K8s 1.1.x is compatible with Consul 1.15.x, so users should be past 1.12 when upgrading to either of the backported versions (compatibility matrix).
How I've tested this PR:
Checklist:
Overview of commits