Backport of Spatel/net 1646 add max ejection percent and base ejection time into release/1.1.x#2107
Merged
malizz merged 2 commits intorelease/1.1.xfrom May 9, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/spatel/NET-1646-add-max-ejection-percent-and-base-ejection-time/manually-charming-koala
branch
from
862f3ce to
7bee8e3
Compare
|
|
Contributor
|
This backport needs fixing from the looks of it |
Contributor
|
heh. this PR needs rebasing as well 😅 |
malizz
force-pushed
the
backport/spatel/NET-1646-add-max-ejection-percent-and-base-ejection-time/manually-charming-koala
branch
from
fa290fb to
282d694
Compare
added 2 commits
May 9, 2023 13:02
malizz
force-pushed
the
backport/spatel/NET-1646-add-max-ejection-percent-and-base-ejection-time/manually-charming-koala
branch
from
282d694 to
9eaf869
Compare
thisisnotashwin
approved these changes
May 9, 2023
malizz
deleted the
backport/spatel/NET-1646-add-max-ejection-percent-and-base-ejection-time/manually-charming-koala
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2064 to be assessed for backporting due to the inclusion of the label backport/1.1.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
add max ejection percent and base ejection time to passiveHealthCheck
How I've tested this PR: local test and with wan federation setup
How I expect reviewers to test this PR:
Checklist:
Overview of commits