Conversation
Website has linting that errors when links have the developer.hashicorp.com prefix.
lkysow
added
pr/no-changelog
david-yu
approved these changes
Mar 21, 2023
Contributor
|
Also cc @im2nguyen who should review this as well. |
im2nguyen
approved these changes
Mar 21, 2023
| docsStr := strings.Join(children, "\n\n") | ||
| docsStr = strings.ReplaceAll(docsStr, "[Enterprise Only]", "<EnterpriseAlert inline />") | ||
| // Remove https://developer.hashicorp.com prefix from links because docs linting requires it. | ||
| docsStr = strings.ReplaceAll(docsStr, "https://developer.hashicorp.com/", "/") |
Contributor
There was a problem hiding this comment.
this should work. just wanted to call out that consul's docs live at https://developer.hashicorp.com/consul/docs, does this account for the /consul?
Contributor
There was a problem hiding this comment.
just confirmed that it does, feel free to merge when ready!
asheshvidyut
pushed a commit
that referenced
this pull request
Aug 4, 2023
Website has linting that errors when links have the developer.hashicorp.com prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Website has linting that errors when links have the developer.hashicorp.com prefix.