[COMPLIANCE] add copyright headers to files#2016
Merged
roncodingenthusiast merged 4 commits intomainfrom Mar 28, 2023
Merged
Conversation
roncodingenthusiast
requested review from
a team,
dlaguerta,
kisunji and
skpratt
and removed request for
a team
roncodingenthusiast
added
pr/no-changelog
skpratt
approved these changes
Mar 15, 2023
dlaguerta
approved these changes
Mar 15, 2023
kisunji
approved these changes
Mar 15, 2023
Contributor
|
Btw it does look like there are some actual failures in unit tests that need to be fixed before merging. |
eikenb
reviewed
Mar 22, 2023
There was a problem hiding this comment.
Do we need copyright headers on generated, test/mock files?
Contributor
Author
There was a problem hiding this comment.
probably not critical to have them, I am removing some of them
roncodingenthusiast
force-pushed
the
copyright-config-file
branch
from
bbd0ab1 to
4f00647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I expect reviewers to test this PR: