Add SNI skip for client node configuration#2013
Merged
andrewstucki merged 2 commits intomainfrom Mar 14, 2023
Merged
Conversation
ishustava
approved these changes
Mar 14, 2023
nathancoleman
approved these changes
Mar 14, 2023
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This adds a fix for where we were injecting an server name env variable to the gateway controller in the case of trying to connect to client agent nodes when we had an external server with an SNI override.
What that results in is a TLS certificate verification error because the controller, when attempting to talk to the client node, then winds up expecting the client certificate to match the external server's name.
How I've tested this PR:
Unit tested.
Checklist: