Backport of NET-1721: Automatic ACL bootstrap with Vault secrets backend into release/1.1.x#1988
Merged
hc-github-team-consul-core merged 6 commits intorelease/1.1.xfrom Mar 6, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/pglass/NET-1721-vault-secrets-backend-boostrap/rightly-better-crow
branch
from
6252348 to
28e9149
Compare
hc-github-team-consul-core
deleted the
backport/pglass/NET-1721-vault-secrets-backend-boostrap/rightly-better-crow
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #1920 to be assessed for backporting due to the inclusion of the label backport/1.1.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
This updates server-acl-init to support automatic ACL bootstrapping when using the Vault secrets backend.
In order to accomplish this, the server-acl-init job runs the Vault agent as a sidecar (in addition to running as an init container). If the bootstrap token is not found in Vault, then server-acl-init will proceed with ACL bootstrapping and write the token back to Vault.
Because server-acl-init writes to Vault via the Vault agent, server-acl-init doesn't have to worry specifying a Vault token or TLS config that it would normally need to talk to the Vault servers.
This adds the Vault SDK to the control-plane binary, which is +1 MB to the consul-k8s-control-plane binary size (74MB to 75MB).
Related to #1176
How I've tested this PR:
Acceptance tests
How I expect reviewers to test this PR:
👀
Checklist:
Overview of commits