Skip to content

Mw/add backport checker#1982

Merged
wilkermichael merged 2 commits intomainfrom
mw/add-backport-checker
Mar 3, 2023
Merged

Mw/add backport checker#1982
wilkermichael merged 2 commits intomainfrom
mw/add-backport-checker

Conversation

@wilkermichael
Copy link
Copy Markdown
Contributor

@wilkermichael wilkermichael commented Mar 3, 2023 •
edited
Loading

Changes proposed in this PR:

  • Add a pipeline check for backport labels. This will ensure that developers must either add a backport label or deliberately specify that this pr does not require backporting with the pr/no-backport label.
  • This check simply checks for the presence of a label matching backport/*. It is up to the developer to add the right backport labels as appropriate for a given PR.

How I've tested this PR:

No Backport label and no pr/no-backport
image

With backport label
image

With pr/no-backport label
image

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@wilkermichael wilkermichael added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.0.x pr/no-backport signals that a PR will not contain a backport label and removed backport/1.0.x pr/no-backport signals that a PR will not contain a backport label labels Mar 3, 2023
@wilkermichael wilkermichael force-pushed the mw/add-backport-checker branch 5 times, most recently from f7c6398 to 1d93115 Compare March 3, 2023 19:51
@wilkermichael wilkermichael added pr/no-backport signals that a PR will not contain a backport label and removed pr/no-backport signals that a PR will not contain a backport label labels Mar 3, 2023
@wilkermichael wilkermichael force-pushed the mw/add-backport-checker branch from 9721b10 to f91079c Compare March 3, 2023 19:58
@wilkermichael wilkermichael added backport/1.0.x pr/no-backport signals that a PR will not contain a backport label and removed backport/1.0.x pr/no-backport signals that a PR will not contain a backport label labels Mar 3, 2023
@wilkermichael wilkermichael force-pushed the mw/add-backport-checker branch from 475a82c to d482dd9 Compare March 3, 2023 20:24
@wilkermichael wilkermichael marked this pull request as ready for review March 3, 2023 20:25
@wilkermichael wilkermichael requested review from a team, ndhanushkodi and thisisnotashwin and removed request for a team March 3, 2023 20:25
@wilkermichael wilkermichael added the backport/1.1.x Backport to release/1.1.x branch label Mar 3, 2023
@wilkermichael wilkermichael merged commit c0e5c69 into main Mar 3, 2023
@wilkermichael wilkermichael deleted the mw/add-backport-checker branch March 3, 2023 21:03
This was referenced Mar 3, 2023
Merged
Merged
Merged
asheshvidyut pushed a commit that referenced this pull request Aug 4, 2023
@wilkermichael
Mw/add backport checker (#1982)
9812055 
* fix grammar in changelog checker

* add backport checker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curtbushko curtbushko curtbushko approved these changes

@ndhanushkodi ndhanushkodi Awaiting requested review from ndhanushkodi ndhanushkodi was automatically assigned from hashicorp/consul-core-service-mesh

+1 more reviewer

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/1.1.x Backport to release/1.1.x branch pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wilkermichael @curtbushko @thisisnotashwin