Skip to content

Cherry pick go changelog 1 0#1960

Merged
wilkermichael merged 1 commit intorelease/1.0.xfrom
cherry-pick-go-changelog-1-0
Feb 28, 2023
Merged

Cherry pick go changelog 1 0#1960
wilkermichael merged 1 commit intorelease/1.0.xfrom
cherry-pick-go-changelog-1-0

Conversation

@wilkermichael
Copy link
Copy Markdown
Contributor

Changes proposed in this PR:

  • manual cherry pick since cherry pick failed

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

- Prepare release now requires an additional LAST_RELEASE_GIT_TAG environment variable required by go-changelog
- removed adding the unreleased tag to the Changelog as we will no longer be doing that. All changelog entries will be added at the time of release by the go-changelog tool
@wilkermichael wilkermichael requested review from a team, curtbushko and erichaberkorn and removed request for a team February 28, 2023 19:46
@wilkermichael wilkermichael changed the base branch from main to release/1.0.x February 28, 2023 19:46
@wilkermichael wilkermichael added pr/no-changelog PR does not need a corresponding .changelog entry and removed pr/no-changelog PR does not need a corresponding .changelog entry labels Feb 28, 2023
@wilkermichael wilkermichael merged commit b38b1a3 into release/1.0.x Feb 28, 2023
@wilkermichael wilkermichael deleted the cherry-pick-go-changelog-1-0 branch February 28, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants