Skip to content

Dockerfile: bump Alpine base image to 3.17#1934

Merged
david-yu merged 2 commits intomainfrom
dyu/dockerfile
Feb 22, 2023
Merged

Dockerfile: bump Alpine base image to 3.17#1934
david-yu merged 2 commits intomainfrom
dyu/dockerfile

Conversation

@david-yu
Copy link
Copy Markdown
Contributor

Changes proposed in this PR:

  • Bump alpine base image to alpine:3.17

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@david-yu david-yu added backport/0.49.x backport/1.1.x Backport to release/1.1.x branch labels Feb 22, 2023
@david-yu david-yu requested a review from curtbushko February 22, 2023 03:14
Copy link
Copy Markdown
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update envoy-alpine? I see several references to it.

hack/helm-reference-gen/fixtures/full-values.yaml: imageEnvoy: "envoyproxy/envoy-alpine:v1.16.0"
hack/helm-reference-gen/fixtures/full-values.golden: - imageEnvoy ((#v-global-imageenvoy)) (string: envoyproxy/envoy-alpine:v1.16.0) - The name (and tag) of the Envoy Docker image used for the
CHANGELOG.md: * Changes default Envoy Docker image (-envoy-image) to envoyproxy/envoy-alpine:v1.13.0

CHANGELOG.md: * Changes default Envoy Docker image (-envoy-image) to envoyproxy/envoy-alpine:v1.13.0
charts/demo/templates/nginx.yaml: image: nginx:alpine

@david-yu
Copy link
Copy Markdown
Contributor Author

@curtbushko It looks like that is mainly the fixtures within the helm gen docs and the changelog. So I don't think that is necessary. The nginx one is just an alpine tag so that should be maintained by the nginx repo.

Copy link
Copy Markdown
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.1.x Backport to release/1.1.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants