Skip to content

Include allowed presets in err msg#1933

Merged
lkysow merged 2 commits intomainfrom
lkysow/preset-errors
Feb 22, 2023
Merged

Include allowed presets in err msg#1933
lkysow merged 2 commits intomainfrom
lkysow/preset-errors

Conversation

@lkysow
Copy link
Copy Markdown
Contributor

@lkysow lkysow commented Feb 22, 2023

consul-k8s install -preset demo
'demo' is not a valid preset

=>

consul-k8s install -preset demo                                                                                                                                                                                                                                                                                                                      
'demo' is not a valid preset (valid presets: cloud, quickstart, secure)

How I've tested this PR:

  • manually and with tests added

How I expect reviewers to test this PR:

  • 👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@lkysow
Copy link
Copy Markdown
Contributor Author

lkysow commented Feb 22, 2023

Not sure this one is worth a changelog?

Copy link
Copy Markdown
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you! this is great.

@lkysow lkysow merged commit bd7a752 into main Feb 22, 2023
@lkysow lkysow deleted the lkysow/preset-errors branch February 22, 2023 16:54
asheshvidyut pushed a commit that referenced this pull request Aug 4, 2023
* Include allowed presets in err msg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants