pinned consul test image to latest dev nightly#1901
Merged
wilkermichael merged 2 commits intomainfrom Feb 14, 2023
Merged
Conversation
- created a new variable for setting the consul test image used for the majority of tests - fixed some incorrect spacing
2 tasks
curtbushko
approved these changes
Feb 13, 2023
david-yu
pushed a commit
that referenced
this pull request
Feb 14, 2023
* pinned consul test image to latest dev nightly - created a new variable for setting the consul test image used for the majority of tests - fixed some incorrect spacing * updated builtin lambda envoy extensions in tests
ishustava
pushed a commit
that referenced
this pull request
Feb 18, 2023
* pinned consul test image to latest dev nightly - created a new variable for setting the consul test image used for the majority of tests - fixed some incorrect spacing * updated builtin lambda envoy extensions in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Undoes #1831 to use the latest consul-ent 1.15 dev images for circli ci acceptance tests so that I can truly verify that NET-2343 is fixed.
Also:
How I've tested this PR:
If the pipeline passes we're good to go
How I expect reviewers to test this PR:
👀
Checklist: