When configured, use the health check of the proxy#1841
Merged
thisisnotashwin merged 2 commits intomainfrom Jan 19, 2023
Merged
When configured, use the health check of the proxy#1841thisisnotashwin merged 2 commits intomainfrom
thisisnotashwin merged 2 commits intomainfrom
Conversation
- When a service is configured with the correct annotation, a readiness endpoint with be configured in Consul dataplane and the readiness probe of the sidecar will be configured to use that endpoint to determine the health of the system. Additionally, when t-proxy is enabled, that port shall be in the ExcludeList for inbound connections.
d74b401 to
f77b0e5
Compare
ishustava
approved these changes
Jan 18, 2023
Contributor
ishustava
left a comment
There was a problem hiding this comment.
Looks great! Just a few comments, but don't think they are blocking.
control-plane/connect-inject/webhook/consul_dataplane_sidecar.go
Outdated
Show resolved
Hide resolved
- Improve changelog wording. - Make useProxyHealthCheck check for all truthy values.
curtbushko
approved these changes
Jan 19, 2023
Contributor
curtbushko
left a comment
There was a problem hiding this comment.
Looks good! I thought I saw something with CNI but you had that covered and our cleanup in 1.0 had unified a bunch of things that makes is so much cleaner (specifically iptablesConfigJSON being used everywhere).
This was referenced Jan 19, 2023
david-yu
pushed a commit
that referenced
this pull request
Feb 14, 2023
* When a service is configured with the correct annotation, a readiness endpoint with be configured in Consul dataplane and the readiness probe of the sidecar will be configured to use that endpoint to determine the health of the system. Additionally, when t-proxy is enabled, that port shall be in the ExcludeList for inbound connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: