Mount certs when using clients even with external servers#1759
Mount certs when using clients even with external servers#1759andrewstucki merged 5 commits intomainfrom
Conversation
| mountPath: /consul-bin | ||
| {{- end }} | ||
| {{- if not (and .Values.externalServers.enabled .Values.externalServers.useSystemRoots) }} | ||
| {{- if or (not (and .Values.externalServers.enabled .Values.externalServers.useSystemRoots)) .Values.client.enabled }} |
There was a problem hiding this comment.
This fix is repeated in 3 spots. It allows the use of certs to talk to local clients when connected to an external server like HCP.
There was a problem hiding this comment.
Update: this is added only here in order to have an auto-encrypt-based cert mounted to establish proper client-node communication if clients are explicitly enabled (in which case our controller still leverages the agent node) -- otherwise we'll try and use the system roots to verify a connection to the client node with a cert provisioned through the auto-encrypt process and the TLS handshake will fail.
curtbushko
left a comment
There was a problem hiding this comment.
Approving so that we can get it in the release for tomorrow
|
@andrewstucki I will be watching this to see if there are any issues. If you don't see any, feel free to do the merge. |
|
@ishustava Looks like the enterprise-control-plane tests are failing, not sure if that's flaky or something just currently broken in but other than that I think this is probably good to go with the smaller-scoped change given the earlier discussion. Let me know if there are any other concerns that you have and thanks again for reviewing. |
|
@andrewstucki looks like this one is a flake. It should be safe to re-run, and if it passes, we're good. |
Mount certs when using clients even with external servers
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: