Fix TLS Cert when using enableAutoEncrypt#1753
Merged
Conversation
ishustava
approved these changes
Nov 28, 2022
c6bf305 to
d486e02
Compare
added 7 commits
November 30, 2022 16:51
…rs on main container
a889467 to
005e147
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
consul-ca-certconsul-ca-certto talk to servers if running without clients. It will useconsul-auto-encrypt-ca-certto talk to clients only if running with clients.How I've tested this PR:
tls.enableAutoEncrypt=falseclient.enabled=falseapiGateway.image=...0.5.1tls.enableAutoEncrypt=trueclient.enabled=falseapiGateway.image=...0.5.1tls.enableAutoEncrypt=falseclient.enabled=trueapiGateway.image=...0.5.1tls.enableAutoEncrypt=trueclient.enabled=trueapiGateway.image=...0.5.1tls.enableAutoEncrypt=trueclient.enabled=trueapiGateway.image=...0.4.0How I expect reviewers to test this PR:
Checklist: