fix acls when peering and partitions are both enabled#1733
Merged
ndhanushkodi merged 4 commits intomainfrom Nov 17, 2022
Merged
fix acls when peering and partitions are both enabled#1733ndhanushkodi merged 4 commits intomainfrom
ndhanushkodi merged 4 commits intomainfrom
Conversation
ndhanushkodi
commented
Nov 17, 2022
.circleci/config.yml
Outdated
| - dev-upload-docker | ||
| - acceptance-gke-1-23: | ||
| requires: | ||
| - dev-upload-docker |
Contributor
Author
There was a problem hiding this comment.
Will remove before merging.
ndhanushkodi
requested review from
a team,
ishustava and
kschoche
and removed request for
a team
thisisnotashwin
approved these changes
Nov 17, 2022
freddygv
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This only happens on a non-default partition when peering and partitions are both enabled, so I found this when testing non-default partitions with ACLs. So this adds a condition to the partition_prefix rule
How I've tested this PR:
manually, on non-default partitions, acceptance tests for other cases
How I expect reviewers to test this PR:
Checklist: