Skip to content

Setting CONSUL_TLS_SERVER_NAME when global.gloud.enabled is set.#1717

Merged
thisisnotashwin merged 1 commit intomainfrom
jm/fix-gnm-server-acl-init
Nov 17, 2022
Merged

Setting CONSUL_TLS_SERVER_NAME when global.gloud.enabled is set.#1717
thisisnotashwin merged 1 commit intomainfrom
jm/fix-gnm-server-acl-init

Conversation

@jmurret
Copy link
Copy Markdown
Member

@jmurret jmurret commented Nov 15, 2022

Changes proposed in this PR:

  • Setting CONSUL_TLS_SERVER_NAME when global.gloud.enabled is set.

How I've tested this PR:

  • manually installed the cloud preset to test this works.
  • unit tests
    How I expect reviewers to test this PR:
    👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@jmurret jmurret force-pushed the jm/fix-gnm-server-acl-init branch from 4f9c7b6 to 3e2f089 Compare November 15, 2022 16:20
Copy link
Copy Markdown
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jmurret jmurret force-pushed the jm/fix-gnm-server-acl-init branch from 3e2f089 to 8318d5a Compare November 16, 2022 17:10
@thisisnotashwin thisisnotashwin merged commit acc4797 into main Nov 17, 2022
@thisisnotashwin thisisnotashwin deleted the jm/fix-gnm-server-acl-init branch November 17, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants