Merge controller subcommand into connect inject subcommand#1697
Merged
thisisnotashwin merged 1 commit intomainfrom Nov 11, 2022
Merged
Merge controller subcommand into connect inject subcommand#1697thisisnotashwin merged 1 commit intomainfrom
thisisnotashwin merged 1 commit intomainfrom
Conversation
thisisnotashwin
force-pushed
the
ashwin/merge-controllers
branch
6 times, most recently
from
f317a11 to
437eee1
Compare
curtbushko
reviewed
Nov 11, 2022
Contributor
curtbushko
left a comment
curtbushko
left a comment
There was a problem hiding this comment.
Looks Good! There are a lot of changes but the tests make this feel a lot safer to do.
I only had a couple questions but nothing I would block you on. Ping me tomorrow if you need an approval.
curtbushko
approved these changes
Nov 11, 2022
ishustava
approved these changes
Nov 11, 2022
Contributor
ishustava
left a comment
ishustava
left a comment
There was a problem hiding this comment.
Awesome work!! Please remember to add a changelog entry with the breaking change
| IngressGateway string = "ingressgateway" | ||
| ``` | ||
| 1. Update `control-plane/subcommand/controller/command.go` and add your controller: | ||
| 1. Update `control-plane/subcommand/inject-connect/command.go` and add your controller: |
thisisnotashwin
force-pushed
the
ashwin/merge-controllers
branch
from
437eee1 to
2c63ccc
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: