Backport of Consul API Gateway, Add Tolerations support into release/0.49.x#1667
Merged
sarahalsmiller merged 1 commit intorelease/0.49.xfrom Nov 4, 2022
Conversation
hc-github-team-consul-ecosystem
force-pushed
the
backport/consul-api-gateway-add-tolerations-support/hardly-enormous-drum
branch
from
ce8bcb9 to
bf83493
Compare
Contributor
|
cc @sarahalsmiller which needs to resolved to be back ported to 0.49.x |
Member
|
Resolving conflicts here in a moment... |
…tions-support Consul API Gateway, Add Tolerations support
nathancoleman
force-pushed
the
backport/consul-api-gateway-add-tolerations-support/hardly-enormous-drum
branch
from
bf83493 to
9629d8f
Compare
Member
|
@sarahalsmiller @david-yu I've resolved merge conflicts here. Please review |
david-yu
approved these changes
Nov 4, 2022
Contributor
david-yu
left a comment
david-yu
left a comment
There was a problem hiding this comment.
Looks good, assuming tests pass, please merge. Thank you.
sarahalsmiller
approved these changes
Nov 4, 2022
sarahalsmiller
deleted the
backport/consul-api-gateway-add-tolerations-support/hardly-enormous-drum
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #1650 to be assessed for backporting due to the inclusion of the label backport/0.49.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist:
Overview of commits