Skip to content

Mw/circle ci stable release testing#1662

Merged
wilkermichael merged 3 commits intomainfrom
mw/circle-ci-stable-release-testing
Nov 3, 2022
Merged

Mw/circle ci stable release testing#1662
wilkermichael merged 3 commits intomainfrom
mw/circle-ci-stable-release-testing

Conversation

@wilkermichael
Copy link
Copy Markdown
Contributor

@wilkermichael wilkermichael commented Oct 31, 2022

Changes proposed in this PR:

  • This PR serves to implement the new testing strategy required by our support of stable releases
  • As always, you can go through my PR commit by commit for more context
  • After this PR we should support the following testing strategy
    • Nightly cloud/kind on main
    • Nightly cloud/kind on release branches (once backported)
    • PR kind tests off of every branch
    • Nightly Consul compatibility tests off of main

What's New:

  • New separate cleanup nightly, this is so that the cleanup step does not conflict with multiple running cloud steps
  • New scheduled nightly that will run on release branches
  • Separate scheduled nightly that will run on main branch, this is so the release branch and main branch nightlies can run at a separate cadence (maybe we'll want to run release nightlies one night a week? a "weekly"?). For now both main and release will run nightly
  • Nightlies now also run the kind-tproxy acceptance tests
  • For now, all nightlies will run at 5 pm PST (12 am UTC) and cleanup will run at 5 am PST (12 pm UTC). We can re-evaluate later what the testing cadence should be.

How I've tested this PR:

  • Ran nightlies at an accelerate schedule. Some tests in the clouds fail, but talked with Iryna these will be fixed in a later PR
  • 👀
    How I expect reviewers to test this PR:
    👀

Checklist:

  • Tests added
  • [N/A] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@wilkermichael wilkermichael force-pushed the mw/circle-ci-stable-release-testing branch 6 times, most recently from 22aabcd to 105bed8 Compare November 2, 2022 17:50
@wilkermichael wilkermichael marked this pull request as ready for review November 2, 2022 17:50
@wilkermichael wilkermichael requested review from a team, ishustava and ndhanushkodi and removed request for a team November 2, 2022 17:51
@wilkermichael wilkermichael force-pushed the mw/circle-ci-stable-release-testing branch from 105bed8 to 7b0461f Compare November 2, 2022 17:56
@wilkermichael wilkermichael force-pushed the mw/circle-ci-stable-release-testing branch from 7b0461f to 3918948 Compare November 3, 2022 16:19
@wilkermichael wilkermichael requested review from ishustava and kschoche and removed request for ishustava November 3, 2022 16:25
Copy link
Copy Markdown
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this Michael!

Comment thread .circleci/config.yml Outdated
Comment thread .circleci/config.yml Outdated
Comment thread .circleci/config.yml
- New scheduled nightly that will run on release branches
- Separate scheduled nightly that will run on main branch, this is so the release branch and main branch nightlies can run at a separate cadence (maybe we'll want to run release nightlies one night a week? a "weekly"?). For now both main and release will run nightly
- Nightlies now also run the kind-tproxy acceptance tests
@wilkermichael wilkermichael force-pushed the mw/circle-ci-stable-release-testing branch from 3918948 to e4b6d3e Compare November 3, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants