Merged
Conversation
jmurret
force-pushed
the
jm/helm-3.9.4
branch
3 times, most recently
from
5211922 to
7b42745
Compare
This reverts commit a448a75.
…1 in EKS module in terraform
jmurret
force-pushed
the
jm/helm-3.9.4
branch
from
7b42745 to
5461895
Compare
ndhanushkodi
approved these changes
Sep 28, 2022
| source = "terraform-aws-modules/eks/aws" | ||
| version = "17.20.0" | ||
| version = "17.24.0" | ||
| kubeconfig_api_version = "client.authentication.k8s.io/v1beta1" |
Contributor
There was a problem hiding this comment.
Not blocking, but was curious what does this do? I see that it's related to the error that you mentioned but was wondering why this line fixes it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is to fix this kubeconfig apiVersion error we see in CI for AWS EKS. It started when aws-cli upgraded its stable version.
Changes proposed in this PR:
consul-helm-testimage to use latestaws-iam-authenticatorversion 0.5.9 which matches aws-cliconsul-helm-testimage which has this fixterraform/aws/eksto use version 17.24.0 so we can setkubeconfig_api_version = "client.authentication.k8s.io/v1beta1".How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: