Merged
Conversation
curtbushko
commented
Aug 25, 2022
.circleci/config.yml
Outdated
| @@ -1089,6 +1158,11 @@ workflows: | |||
| # requires: | |||
| # - cleanup-gcp-resources | |||
Contributor
Author
There was a problem hiding this comment.
Will clean this all up before merging
ishustava
reviewed
Aug 25, 2022
.circleci/config.yml
Outdated
| - run: mkdir -p $TEST_RESULTS | ||
|
|
||
| - run-acceptance-tests: | ||
| additional-flags: -kubeconfig="$primary_kubeconfig" -secondary-kubeconfig="$secondary_kubeconfig" -enable-pod-security-policies -enable-transparent-proxy -enable-cni -enable-gke |
Contributor
There was a problem hiding this comment.
nit: could this flag be called -use-gke similar to -use-kind?
Contributor
Author
There was a problem hiding this comment.
Nit addressed. 😺
ishustava
approved these changes
Aug 25, 2022
Contributor
ishustava
left a comment
ishustava
left a comment
There was a problem hiding this comment.
Looks good! Just one tiny comment
curtbushko
force-pushed
the
curtbushko/cni-acceptance-gke
branch
2 times, most recently
from
c72ac62 to
de02979
Compare
curtbushko
force-pushed
the
curtbushko/cni-acceptance-gke
branch
from
de02979 to
83c8100
Compare
- Added a new make target for installing Calico CNI in Kind. The target installs Calico CNI using config files located under /acceptance tests - Added a helper make target for setting up local Kind with Calico just in case anyone wants to run it. - Added a kind.config for setting up the Kind cluster - Added an -enable-cni flag to the acceptance test config so that it can be passed through from CircleCI - Added a nightly circleci job for running the CNI kind tests - I had missed a bats test for the connect-inject template that I merged in a previous PR
…connectInject.cni.enabled from several files as the framework will set this when the flag is passed in
- Added a -ue-gke flag to the acceptance test command so that the flag can be passed through to the tests - If both, -enable-cni and -ue-gke are passed through then the cniBinDir gets set for helm values. - GKE would not install the CNI plugin unless the use security policy was set. - GKE was throwing an error saying that allowPrivilegeEscalation: true needed to be set if privileged: true. Once set, tests passed.
curtbushko
force-pushed
the
curtbushko/cni-acceptance-gke
branch
from
83c8100 to
aeb3f2e
Compare
curtbushko
added a commit
that referenced
this pull request
Aug 26, 2022
- Added a -use-gke flag to the acceptance test command so that the flag can be passed through to the tests - If both, -enable-cni and -use-gke are passed through then the cniBinDir gets set for helm values. - GKE would not install the CNI plugin unless the use security policy was set. - GKE was throwing an error saying that allowPrivilegeEscalation: true needed to be set if privileged: true. Once set, tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the CNI acceptance tests on Kind PR to get things running on GKE.
GKE is the only cloud platform that has a different requirement for
connectInject.cni.cniBinDirand does not use the default. The consul-cni binary needs to be installed to/home/kubernetes/bin.Changes proposed in this PR:
-use-gkeflag to the acceptance test command so that the flag can be passed through to the tests-enable-cniand-use-gkeare passed through then the cniBinDir gets set for helm values.usesecurity policy was set.allowPrivilegeEscalation: trueneeded to be set ifprivileged: true. Once set, tests passed.How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: