Skip to content

Actually disable mesh gateway tests on kind! #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ishustava merged 1 commit into from
Jul 19, 2022
Merged

Actually disable mesh gateway tests on kind! #1351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions acceptance/tests/mesh-gateway/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@ var suite testsuite.Suite
func TestMain(m *testing.M) {
suite = testsuite.NewSuite(m)

if suite.Config().EnableMultiCluster {
os.Exit(suite.Run())
} else if suite.Config().UseKind {
if suite.Config().UseKind {
Copy link
Copy Markdown
Contributor

@lkysow lkysow Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah Go evaluates the first if conditional before the next else if

fmt.Println("Skipping mesh gateway tests because they are currently flaky on kind")
os.Exit(0)
}
if suite.Config().EnableMultiCluster {
os.Exit(suite.Run())
} else {
fmt.Println("Skipping mesh gateway tests because -enable-multi-cluster is not set")
os.Exit(0)
Expand Down