Fixes #4 and #11: Include ClusterIP services and avoid empty namespaces#13
Closed
jackpizarro wants to merge 2 commits intohashicorp:masterfrom
Closed
Fixes #4 and #11: Include ClusterIP services and avoid empty namespaces#13jackpizarro wants to merge 2 commits intohashicorp:masterfrom
jackpizarro wants to merge 2 commits intohashicorp:masterfrom
Conversation
jackpizarro
changed the title
t-eckert
pushed a commit
that referenced
this pull request
Sep 8, 2022
# This is the 1st commit message: Add service for terminating-gateways # This is the commit message #2: Add gateway-kind:terminating to deployment # This is the commit message #3: Add registration path for terminating gateways # This is the commit message #4: Add BATS tests # This is the commit message #5: Remove registration from terminating gateways deployment # This is the commit message #6: Set ports AFAIK in service # This is the commit message #7: Begin setting values for endpoints controller # This is the commit message #8: Copy values from deployment to endpoints controller (as comment) # This is the commit message #9: Use connect-init instead of acl-init # This is the commit message #10: Remove guards from term gw service (they will get hit by the deployment) # This is the commit message #11: Range over gateways to produce a service for each deployment # This is the commit message #12: Add test for multiple gateways # This is the commit message #13: Remove the format script # This is the commit message #14: Note which parts of the config have been set
jmurret
added a commit
that referenced
this pull request
Sep 27, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
added a commit
that referenced
this pull request
Sep 27, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
added a commit
that referenced
this pull request
Sep 27, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
added a commit
that referenced
this pull request
Sep 27, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
added a commit
that referenced
this pull request
Sep 28, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
added a commit
that referenced
this pull request
Sep 28, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
added a commit
that referenced
this pull request
Sep 28, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
added a commit
that referenced
this pull request
Sep 29, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
added a commit
that referenced
this pull request
Oct 5, 2022
* support for HCP_SCADA_ADDRESS * set scada address via env * add server-statefuleset bats tests for HCP_SCADA_ADDRESS * add scada address tests to cloud preset tests Co-authored-by: John Murret <john.murret@hashicorp.com>
wilkermichael
pushed a commit
that referenced
this pull request
Oct 17, 2022
wilkermichael
pushed a commit
that referenced
this pull request
Oct 18, 2022
wilkermichael
pushed a commit
that referenced
this pull request
Oct 18, 2022
wilkermichael
pushed a commit
that referenced
this pull request
Oct 18, 2022
wilkermichael
pushed a commit
that referenced
this pull request
Oct 19, 2022
ishustava
pushed a commit
that referenced
this pull request
Feb 18, 2023
…nsul-635-update-mesh_webhook_test.go-add-isWindows-test [CONSUL-635] Add isWindows Test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to get the ball rolling on this, works for me but not sure if this is the proper way to do it.