Bump default Envoy version to 1.22.2#1276
Merged
thisisnotashwin merged 3 commits intomainfrom Jun 15, 2022
Merged
Conversation
Contributor
ndhanushkodi
left a comment
ndhanushkodi
left a comment
There was a problem hiding this comment.
I think we can remove the changes in the files _types.go and re-run make ctrl-manifests again, since those are still valid comments as is.
Thank you for doing this!!!
| // One of `TLS_AUTO`, `TLSv1_0`, `TLSv1_1`, `TLSv1_2`, or `TLSv1_3`. | ||
| // If unspecified, Envoy v1.22.0 and newer will default to TLS 1.2 as a min version, | ||
| // If unspecified, Envoy v1.22.2 and newer will default to TLS 1.2 as a min version, | ||
| // while older releases of Envoy default to TLS 1.0. |
Contributor
There was a problem hiding this comment.
Similar to above I think we can remove this, and run make ctrl-manifests again.
eculver
force-pushed
the
CTIA-31-envoy-latest
branch
from
951f2b5 to
5ff5d19
Compare
thisisnotashwin
approved these changes
Jun 15, 2022
Contributor
thisisnotashwin
left a comment
thisisnotashwin
left a comment
There was a problem hiding this comment.
Approving in lieu of the comment being reverted to the older version and the CRDs getting re-generated.
Contributor
|
Thanks so much for doing this @eculver !! |
Contributor
Author
Thanks! It has been reverted. |
david-yu
approved these changes
Jun 15, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy recently released patches for all their supported versions (ref). This goes along with hashicorp/consul#13431 to bump the version of Envoy to the latest patches available.
Changes proposed in this PR:
make ctrl-manifeststo generate manifest yamlHow I've tested this PR:
I no longer see any references to 1.22.0 in the code unless it's not for Envoy.
How I expect reviewers to test this PR:
Please make sure I didn't miss any places where this version should be updated.
Checklist:
[ ] Tests added