Skip to content

Update consul-helm-test with go 1.17#1177

Merged
thisisnotashwin merged 2 commits intomainfrom
ashwin/fix-go-sum
Apr 19, 2022
Merged

Update consul-helm-test with go 1.17#1177
thisisnotashwin merged 2 commits intomainfrom
ashwin/fix-go-sum

Conversation

@thisisnotashwin
Copy link
Copy Markdown
Contributor

@thisisnotashwin thisisnotashwin commented Apr 19, 2022

Changes proposed in this PR:

  • Update the bats version in the Dockerfile.
  • Update the go.sum as they were missing dependencies.
  • Update consul-helm-test with go 1.17

How I've tested this PR:
👀 pipelines
How I expect reviewers to test this PR:
👀 pipeline

@thisisnotashwin thisisnotashwin requested review from a team, jmurret and kschoche and removed request for a team April 19, 2022 18:32
Copy link
Copy Markdown
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so happy to finally have this RELEASE-NAME vs release-name nonsense fixed!!
<3
Looks like there is a merge conflict tho :)

- Update the bats version in the Dockerfile.
- Update the go.sum as they were missing dependencies.
Copy link
Copy Markdown
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thisisnotashwin thisisnotashwin merged commit 68bcc72 into main Apr 19, 2022
@thisisnotashwin thisisnotashwin deleted the ashwin/fix-go-sum branch April 19, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants