-
Notifications
You must be signed in to change notification settings - Fork 334
[CRT] Build docker images, rpms and debs #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5597e56
[CRT] Build docker images, rpms and debs
curtbushko e2a222c
Updates based on PR comments
curtbushko 7e96d76
add arm64 support
curtbushko 1657e8c
Make dockerfile dev target almost the same so that circle ci uses the…
curtbushko 0be2c94
Use ci.dev-docker in circleci
curtbushko 5c1ec66
Disable UBI build
curtbushko 41b935c
remove cb/crt-change-to-multi-target-dockerfile branch from build.yml
curtbushko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,264 @@ | ||
| name: build | ||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| # Sequence of patterns matched against refs/heads | ||
| branches: | ||
| # Push events on main branch | ||
| - main | ||
| # Push events to branches matching refs/heads/release/** | ||
| - "release/**" | ||
|
|
||
| env: | ||
| PKG_NAME: "consul-k8s-control-plane" | ||
|
|
||
| jobs: | ||
| get-go-version: | ||
| name: "Determine Go toolchain version" | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| go-version: ${{ steps.get-go-version.outputs.go-version }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Determine Go version | ||
| id: get-go-version | ||
| # We use .go-version as our source of truth for current Go | ||
| # version, because "goenv" can react to it automatically. | ||
| run: | | ||
| echo "Building with Go $(cat .go-version)" | ||
| echo "::set-output name=go-version::$(cat .go-version)" | ||
|
|
||
| get-product-version: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| product-version: ${{ steps.get-product-version.outputs.product-version }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: get product version | ||
| id: get-product-version | ||
| run: | | ||
| make version | ||
| echo "::set-output name=product-version::$(make version)" | ||
|
|
||
| generate-metadata-file: | ||
| needs: get-product-version | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| filepath: ${{ steps.generate-metadata-file.outputs.filepath }} | ||
| steps: | ||
| - name: "Checkout directory" | ||
| uses: actions/checkout@v2 | ||
| - name: Generate metadata file | ||
| id: generate-metadata-file | ||
| uses: hashicorp/actions-generate-metadata@v1 | ||
| with: | ||
| version: ${{ needs.get-product-version.outputs.product-version }} | ||
| product: ${{ env.PKG_NAME }} | ||
| repositoryOwner: "hashicorp" | ||
| - uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: metadata.json | ||
| path: ${{ steps.generate-metadata-file.outputs.filepath }} | ||
|
|
||
| build: | ||
| needs: [get-go-version, get-product-version] | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| # cli | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "freebsd", goarch: "386", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "freebsd", goarch: "amd64", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "linux", goarch: "386", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "linux", goarch: "amd64", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "linux", goarch: "arm", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "linux", goarch: "arm64", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "windows", goarch: "386", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "windows", goarch: "amd64", component: "cli", pkg_name: "consul-k8s" } | ||
| # control-plane | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "freebsd", goarch: "386", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "freebsd", goarch: "amd64", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "linux", goarch: "386", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "linux", goarch: "amd64", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "linux", goarch: "arm", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "linux", goarch: "arm64", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| # solaris is only built for the control plane | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "solaris", goarch: "amd64", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "windows", goarch: "386", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "windows", goarch: "amd64", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "darwin", goarch: "amd64", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "darwin", goarch: "amd64", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
|
lkysow marked this conversation as resolved.
|
||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "darwin", goarch: "arm64", component: "cli", pkg_name: "consul-k8s" } | ||
| - {go: "${{ needs.get-go-version.outputs.go-version }}", goos: "darwin", goarch: "arm64", component: "control-plane", pkg_name: "consul-k8s-control-plane" } | ||
| fail-fast: true | ||
|
|
||
| name: Go ${{ matrix.go }} ${{ matrix.goos }} ${{ matrix.goarch }} ${{ matrix.component }} build | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Setup go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: ${{ matrix.go }} | ||
|
|
||
| - name: Build | ||
| env: | ||
| GOOS: ${{ matrix.goos }} | ||
| GOARCH: ${{ matrix.goarch }} | ||
| CGO_ENABLED: 0 | ||
| working-directory: ${{ matrix.component }} | ||
| run: | | ||
| mkdir -p dist out | ||
| GCO_ENABLED=0 go build -o dist/${{ matrix.pkg_name }} . | ||
| zip -r -j out/${{ matrix.pkg_name }}_${{ needs.get-product-version.outputs.product-version }}_${{ matrix.goos }}_${{ matrix.goarch }}.zip dist/ | ||
|
|
||
| - name: Upload built binaries | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: ${{ matrix.pkg_name }}_${{ needs.get-product-version.outputs.product-version }}_${{ matrix.goos }}_${{ matrix.goarch }}.zip | ||
| path: ${{ matrix.component}}/out/${{ matrix.pkg_name }}_${{ needs.get-product-version.outputs.product-version }}_${{ matrix.goos }}_${{ matrix.goarch }}.zip | ||
|
|
||
| - name: Package rpm and deb files | ||
|
curtbushko marked this conversation as resolved.
|
||
| if: ${{ matrix.goos == 'linux' && matrix.component == 'cli' && matrix.goarch == 'amd64'}} | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It turns out that we only ship AMD64 rpm and debs (verified through the rpm upload website and in our docs). Most HC products only support AMD64 for rpm and debs |
||
| uses: hashicorp/actions-packaging-linux@v1 | ||
| with: | ||
| name: consul-k8s | ||
| description: "consul-k8s provides a cli interface to first-class integrations between Consul and Kubernetes." | ||
| arch: ${{ matrix.goarch }} | ||
| version: ${{ needs.get-product-version.outputs.product-version }} | ||
| maintainer: "HashiCorp" | ||
| homepage: "https://github.com/hashicorp/consul-k8s" | ||
| license: "MPL-2.0" | ||
| binary: "${{ matrix.component }}/dist/${{ matrix.pkg_name }}" | ||
| deb_depends: "openssl" | ||
| rpm_depends: "openssl" | ||
|
|
||
| - name: Set package names | ||
| if: ${{ matrix.goos == 'linux' && matrix.component == 'cli' && matrix.goarch == 'amd64'}} | ||
| run: | | ||
| echo "RPM_PACKAGE=$(basename out/*.rpm)" >> $GITHUB_ENV | ||
| echo "DEB_PACKAGE=$(basename out/*.deb)" >> $GITHUB_ENV | ||
|
|
||
| - name: Test rpm package | ||
| if: ${{ matrix.goos == 'linux' && matrix.component == 'cli' && matrix.goarch == 'amd64'}} | ||
| uses: addnab/docker-run-action@v3 | ||
| with: | ||
| image: registry.access.redhat.com/ubi8/ubi:latest | ||
| options: -v ${{ github.workspace }}:/work | ||
| run: | | ||
| dnf install -qy openssl | ||
| cd /work | ||
| rpm -ivh out/${{ env.RPM_PACKAGE }} | ||
| CONSUL_K8S_VERSION="$(consul-k8s version | awk '{print $2}')" | ||
| VERSION="${{ needs.get-product-version.outputs.product-version }}" | ||
| if [ "${VERSION}" != "${CONSUL_K8S_VERSION}" ]; then | ||
| echo "Test FAILED, expected: ${VERSION}, got: ${CONSUL_K8S_VERSION}" | ||
| exit 1 | ||
| fi | ||
| echo "Test PASSED, expected: ${VERSION}, got: ${CONSUL_K8S_VERSION}" | ||
|
|
||
| - name: Upload rpm package | ||
| uses: actions/upload-artifact@v2 | ||
| if: ${{ matrix.goos == 'linux' && matrix.component == 'cli' && matrix.goarch == 'amd64'}} | ||
| with: | ||
| name: ${{ env.RPM_PACKAGE }} | ||
| path: out/${{ env.RPM_PACKAGE }} | ||
|
|
||
| - name: Test debian package | ||
| if: ${{ matrix.goos == 'linux' && matrix.component == 'cli' && matrix.goarch == 'amd64'}} | ||
| uses: addnab/docker-run-action@v3 | ||
| with: | ||
| image: ubuntu:latest | ||
| options: -v ${{ github.workspace }}:/work | ||
| run: | | ||
| apt update && apt install -y openssl | ||
| cd /work | ||
| apt install ./out/${{ env.DEB_PACKAGE }} | ||
| CONSUL_K8S_VERSION="$(consul-k8s version | awk '{print $2}')" | ||
| VERSION="${{ needs.get-product-version.outputs.product-version }}" | ||
| if [ "${VERSION}" != "${CONSUL_K8S_VERSION}" ]; then | ||
| echo "Test FAILED, expected: ${VERSION}, got: ${CONSUL_K8S_VERSION}" | ||
| exit 1 | ||
| fi | ||
| echo "Test PASSED, expected: ${VERSION}, got: ${CONSUL_K8S_VERSION}" | ||
|
|
||
| - name: Upload debian packages | ||
| uses: actions/upload-artifact@v2 | ||
| if: ${{ matrix.goos == 'linux' && matrix.component == 'cli' && matrix.goarch == 'amd64'}} | ||
| with: | ||
| name: ${{ env.DEB_PACKAGE }} | ||
| path: out/${{ env.DEB_PACKAGE }} | ||
|
|
||
| build-docker-default: | ||
| name: Docker ${{ matrix.arch }} default release build | ||
| needs: [get-product-version, build] | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| arch: ["arm", "arm64", "386", "amd64"] | ||
| env: | ||
| repo: ${{ github.event.repository.name }} | ||
| version: ${{ needs.get-product-version.outputs.product-version }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Docker Build (Action) | ||
| uses: hashicorp/actions-docker-build@v1.2.1 | ||
| with: | ||
| smoke_test: | | ||
| TEST_VERSION="$(docker run "${IMAGE_NAME}" consul-k8s-control-plane version | awk '{print $2}')" | ||
| if [ "${TEST_VERSION}" != "${version}" ]; then | ||
| echo "Test FAILED" | ||
| exit 1 | ||
| fi | ||
| echo "Test PASSED" | ||
| version: ${{ env.version }} | ||
| target: release-default | ||
| arch: ${{ matrix.arch }} | ||
| pkg_name: consul-k8s-control-plane_${{ env.version }} | ||
| bin_name: consul-k8s-control-plane | ||
| workdir: control-plane | ||
| tags: | | ||
| docker.io/hashicorp/${{ env.repo }}-control-plane:${{ env.version }} | ||
| 986891699432.dkr.ecr.us-east-1.amazonaws.com/hashicorp/${{ env.repo }}-control-plane:${{ env.version }} | ||
| dev_tags: | | ||
| hashicorppreview/${{ env.repo }}-control-plane:${{ env.version }}-dev | ||
| docker.io/hashicorppreview/${{ env.repo }}-control-plane:${{ env.version }}-${{ github.sha }} | ||
|
|
||
| # Disabling UBI build for now so that we do not inadvertently push a ubi image that we have not tested. | ||
| # build-docker-alternate: | ||
| # name: Docker ${{ matrix.arch }} alternate release build | ||
| # needs: [get-product-version, build] | ||
| # runs-on: ubuntu-latest | ||
| # strategy: | ||
| # matrix: | ||
| # arch: ["amd64"] | ||
| # env: | ||
| # repo: ${{ github.event.repository.name }} | ||
| # version: ${{ needs.get-product-version.outputs.product-version }} | ||
| # | ||
| # steps: | ||
| # - uses: actions/checkout@v2 | ||
| # - name: Copy LICENSE.md | ||
| # run: | ||
| # cp LICENSE.md ./control-plane | ||
| # - uses: hashicorp/actions-docker-build@v1.2.1 | ||
| # with: | ||
| # smoke_test: | | ||
| # TEST_VERSION="$(docker run "${IMAGE_NAME}" consul-k8s-control-plane version | awk '{print $2}')" | ||
| # if [ "${TEST_VERSION}" != "${version}" ]; then | ||
| # echo "Test FAILED" | ||
| # exit 1 | ||
| # fi | ||
| # echo "Test PASSED" | ||
| # version: ${{ env.version }} | ||
| # target: ubi | ||
| # arch: ${{ matrix.arch }} | ||
| # pkg_name: consul-k8s-control-plane_${{ env.version }} | ||
| # bin_name: consul-k8s-control-plane | ||
| # workdir: control-plane | ||
| # tags: | | ||
| # registry.connect.redhat.com/hashicorp/consul-k8s-control-plane:${{env.version}}-ubi | ||
| # dev_tags: | | ||
| # hashicorppreview/${{ env.repo }}-control-plane:${{ env.version }}-ubi-dev | ||
| # docker.io/hashicorppreview/${{ env.repo }}-control-plane:${{ env.version }}-ubi-${{ github.sha }} | ||
| # | ||
2 changes: 1 addition & 1 deletion
2
.github/workflows/build-and-test.yml → .github/workflows/test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: test-and-build | ||
| name: test | ||
| on: | ||
| push: | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.