Skip to content

Binary build fixes for Windows#46

Closed
pglass wants to merge 2 commits intomainfrom
pglass/windows-hack
Closed

Binary build fixes for Windows#46
pglass wants to merge 2 commits intomainfrom
pglass/windows-hack

Conversation

@pglass
Copy link

@pglass pglass commented Nov 4, 2022

  • Switch bootstrap config file from a named Unix pipe to a tempfile, since there shouldn't be anything sensitive in the bootstrap config file
  • Remove x-consul-token from the bootstrap config template since the token is injected into the gRPC stream by an interceptor

"key": "x-consul-token",
"value": "{{ .Token }}"
}
],
Copy link
Contributor

@jshahriddhi jshahriddhi Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a generated file, worth implementing the hackery in the makefile helper : https://github.com/hashicorp/consul-dataplane/blob/main/Makefile#L80

@joselo85
Copy link

joselo85 commented Dec 5, 2022

Just to let you know, I am using this code (updated with main branch of course) and using it on Windows nodes in AWS, and for now it seems to work fine!

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 23, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Paul Glass seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@DanStough DanStough closed this May 24, 2024
@github-actions github-actions bot deleted the pglass/windows-hack branch September 1, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants