Conversation
|
@trevorLeonHC, you'll need to add a file https://github.com/hashicorp/consul-dataplane/tree/main/.changelog |
|
You have a few unit tests to clean up. Because the |
2c8f08c to
595a43e
Compare
curtbushko
left a comment
There was a problem hiding this comment.
Thanks! This is looking pretty great! I have a few requests but I am not too sure about the loop thing.
6a57d91 to
7d76013
Compare
30b0b2b to
90ec82c
Compare
split lifecycle tests into separate startup/shutdown
t-eckert
left a comment
There was a problem hiding this comment.
Left a few non-blocking comments. Great work on getting code into production!
curtbushko
left a comment
There was a problem hiding this comment.
I think you covered everything I suggested. Good job!
|
Removing backport labels for clarity as this feature was not backported (exists in 1.3.x+) |
Adding graceful_startup endpoint and function that will be called by dataplane postStart hook. Graceful_startup will block all other containers from starting up until envoy dataplane is determined to be ready.