Conversation
skpratt
force-pushed
the
fips-CRT-updates
branch
5 times, most recently
from
e9cdb8a to
957d346
Compare
skpratt
changed the title
skpratt
force-pushed
the
fips-CRT-updates
branch
from
790d4ea to
fdc135a
Compare
skpratt
added
the
pr/no-changelog
skpratt
force-pushed
the
fips-CRT-updates
branch
from
fdc135a to
bf5026c
Compare
skpratt
requested review from
curtbushko,
emilymianeil,
sarahethompson and
shore
and removed request for
a team
curtbushko
requested changes
Jun 21, 2023
Contributor
curtbushko
left a comment
curtbushko
left a comment
There was a problem hiding this comment.
Looks good! Just one question about debian below
curtbushko
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the release process for consul and consul-k8s earlier this week, CRT arrived at the conclusion that a paradigm using separate targets and container repositories for FIPS versions of Consul products was the preferred way to ensure that FIPS and non-FIPS products do not risk overwriting each other in the pipeline. This PR incorporates those changes for Dataplane, similar to what was done in the k8s PR, as well as enterprise (not linked here):
hashicorp/consul-k8s#2333
This PR also updates the FIPS target in Dataplane to use a FIPS Envoy image.