IND-2779 linting, .go-version fie added #9
Conversation
KaushikiAnand
commented
Mar 27, 2025
KaushikiAnand
commented
- I have added linting to go-tests.yml. .go-version file was added.
- The linting was done to ensure that the codebase is consistent and maintainable and helps in improving the code quality and reducing errors. The .go-version file was added to find the security vulnerabilities in a repo.
cli.go
Outdated
| @@ -190,13 +188,17 @@ func (c *CLI) Run() (int, error) { | |||
|
|
|||
| // Just show the version and exit if instructed. | |||
| if c.IsVersion() && c.Version != "" { | |||
| c.HelpWriter.Write([]byte(c.Version + "\n")) | |||
| if _, err := c.HelpWriter.Write([]byte(c.Version + "\n")); err != nil { | |||
| return 1, err | |||
There was a problem hiding this comment.
Suggestion: error code 1 stands for Operation not permitted which may not be the case here. I think error code 5 will be a better fit over here
There was a problem hiding this comment.
replaced error code to 5 from 1 for all write errors as suggested
cli.go
Outdated
| return 0, nil | ||
| } | ||
|
|
||
| // Just print the help when only '-h' or '--help' is passed. | ||
| if c.IsHelp() && c.Subcommand() == "" { | ||
| c.HelpWriter.Write([]byte(c.HelpFunc(c.helpCommands(c.Subcommand())) + "\n")) | ||
| if _, err := c.HelpWriter.Write([]byte(c.HelpFunc(c.helpCommands(c.Subcommand())) + "\n")); err != nil { | ||
| return 1, err |
There was a problem hiding this comment.
The above statement is valid for all write errors
There was a problem hiding this comment.
replaced error code to 5 from 1 for all write errors as suggested
| @@ -557,12 +564,12 @@ func (c *CLI) commandHelp(out io.Writer, command Command) { | |||
| // Get the command | |||
| raw, ok := subcommands[k] | |||
| if !ok { | |||
| c.ErrorWriter.Write([]byte(fmt.Sprintf( | |||
| _, _ = c.ErrorWriter.Write([]byte(fmt.Sprintf( | |||
There was a problem hiding this comment.
Comment: We should not be leaving out errors but with the current implementation it doesn't give a lot of options for return values
Maybe we can add a TODO over here to address this later
ui_test.go
Outdated
| errors <- err | ||
| }() | ||
| select { | ||
| case err := <-errors: |
There was a problem hiding this comment.
Suggestion: I dont think you need a select over here. You can move the consumption of errors to after ui.Ask(tc.query) is done
There was a problem hiding this comment.
suggested change has been made.
ui_test.go
Outdated
| errors <- err | ||
| }() | ||
| select { | ||
| case err := <-errors: |
There was a problem hiding this comment.
Suggestion: Can you check if the the consumption of errors can be moved to line 92 over here as well ?
