Authorize contributors to view and patch draft documents #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -540,6 +549,14 @@ func DraftsDocumentHandler( | |||
| l.Info("retrieved document draft", "doc_id", docId) | |||
|
|
|||
| case "DELETE": | |||
| // Authorize request. | |||
There was a problem hiding this comment.
Interesting, I thought this would already be in place for deleting documents. 😄
There was a problem hiding this comment.
We were! 🙂 We were only authorizing draft owners for all methods before this PR, and now with this PR we authorize owners+contributors for all methods, and this is extra authorization to only allow owners to delete drafts.
anubhavmishra
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only doc owners can access a draft document through Hermes even though we share the Google Doc with contributors. This PR allows contributors to view and patch draft documents through Hermes. Delete access is still restricted to document owners.