Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip modifier #93

Merged
merged 9 commits into from
Mar 22, 2023
Merged

Add tooltip modifier #93

merged 9 commits into from
Mar 22, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Mar 15, 2023

Adds and tests a simple tooltip modifier as a way to attach tooltips to HTMLElements. Powered by Floating UI

Includes styles and a helper utility.

Example usage:

<div {{tooltip "Back to dashboard" position="bottom"}}>
  <FlightIcon @name="arrow-left" />
</div>

@jeffdaley jeffdaley changed the title Jeffdaley/tooltip component Add tooltip modifier Mar 15, 2023
@jeffdaley jeffdaley marked this pull request as ready for review March 21, 2023 20:52
@jeffdaley jeffdaley requested a review from a team as a code owner March 21, 2023 20:52
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good best as I can tell!

@jeffdaley jeffdaley merged commit abf60e8 into main Mar 22, 2023
@jeffdaley jeffdaley deleted the jeffdaley/tooltip-component branch March 22, 2023 23:59
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
* Add FloatingUI package

* Add `tooltip` modifier

* Tests; AssertedHTMLElement; DOM_PARENT

* Add `htmlElement` tests

* Add documentation to modifier

* Rename selector

* Move cleanup registry to constructor

* Move domParent to Modifier class; improve arrow

* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants