Fix indexer logic by refreshing doc headers before indexing #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhavmishra
suggested changes
Mar 10, 2023
| log.Error("error getting drafts headers folder indexer data", | ||
| "error", err, | ||
| ) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Do we want to exit here? Could we retry instead?
There was a problem hiding this comment.
It's a good thought, but we're already exiting for basically all errors in the indexer (there's a TODO above to improve error handling). I'd like to address this more holistically in a future PR.
anubhavmishra
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes improves indexer logic by switching the order of operations where we now refresh document(+drafts) headers before indexing the documents for search. Before this, the indexer could get into a state where it was constantly indexing and refreshing the doc headers each run because the header refreshes would cause the documents to have a new modified time.
It's not exactly a hack, but note that we now track the timestamps of when we refresh headers of all documents in a folder by putting a
refreshHeaders:prefix in thegoogle_drive_idcolumn for these records in theindexer_folderstable.