Move SESSION_STORAGE_KEY out of SessionService
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhavmishra
approved these changes
Mar 14, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
Move variable out of class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
SESSION_STORAGE_KEYvariable out of the SessionService, where it was sometimesundefined.My maybe-crazy theory:
Because SessionService extends EmberSimpleAuthSessionService, there are cases where
this.sessionrefers only to the base class. In theauthenticatedroute,this.session.requireAuthenticationworks because it's part of the base class, whileSESSION_STOAGE_KEYmay come upundefinedbecause it's not.Either way, I haven't seen the
undefineds since making this change.