Poll for expired session #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rge/hermes into jeffdaley/mirage-me
jeffdaley
commented
Mar 28, 2023
Comment on lines
-7
to
+12
| @onDismiss={{this.dismiss}} | ||
| @onDismiss={{close}} |
There was a problem hiding this comment.
We used to pass in a no-op based on the now-outdated idea that dismissOnClick is always true.
jeffdaley
force-pushed
the
jeffdaley/google-pinger
branch
from
85806a6
to
8e907a9
Compare
jfreda
approved these changes
Apr 5, 2023
web/app/services/session.ts
Outdated
Comment on lines
61
to
63
| headers: { | ||
| "Hermes-Google-Access-Token": this.data.authenticated.access_token, | ||
| }, |
There was a problem hiding this comment.
Not strictly necessary because the fetch service adds this automatically for backend requests.
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Add fetch to tsconfig
* Fix type errors
* Show reauthentication toast when logged out
* Add test; add `basicTimeout`
* Set up basic 401 handler
* Move variable out of class
* Update Mirage's `me` handling; Update tests
* Add `isPollCall` argument to fetch
* Add `me` to Mirage; Update tests
* Add `me` to Mirage
* Revert `create('me')` changes
* Add /me endpoint to determine if the user is currently authenticated
* Revert stub endpoint
* Update endpoint
* Cleanup; documentation
* Fix merge error
* Remove redundant headers
---------
Co-authored-by: Josh Freda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a repeating function to check if the user's auth token has expired.
Shows a flashMessage if it is: