Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 screen #76

Merged
merged 11 commits into from
Mar 20, 2023
Merged

Add 404 screen #76

merged 11 commits into from
Mar 20, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Mar 7, 2023

Adds a 404 route:

CleanShot 2023-03-07 at 16 31 21@2x

Waiting on #77

@jeffdaley jeffdaley requested a review from a team as a code owner March 7, 2023 21:33
@jeffdaley jeffdaley marked this pull request as draft March 7, 2023 21:41
@jeffdaley jeffdaley marked this pull request as ready for review March 8, 2023 23:50
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@jeffdaley jeffdaley merged commit 2319d4b into main Mar 20, 2023
@jeffdaley jeffdaley deleted the jeffdaley/404 branch March 20, 2023 13:21
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
* Draft of 404

* Update design

* Fix transitionTo; Add test; MockDate resets

* Revert out-of-scope changes

* Fix merge error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants