Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc::Thumbnail component #75

Merged
merged 19 commits into from
Mar 25, 2023
Merged

Doc::Thumbnail component #75

merged 19 commits into from
Mar 25, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Mar 7, 2023

  • Moves repetitious doc-thumbnail code into a component
  • Tweaks the design to (hopefully) clean up the archived/obsolete state, and to increase consistency across sizes.
  • Adds tests

Current:

CleanShot 2023-03-07 at 14 06 31

1

Proposed:

CleanShot 2023-03-07 at 14 07 47

2

@jeffdaley jeffdaley marked this pull request as ready for review March 7, 2023 19:15
@jeffdaley jeffdaley requested a review from a team as a code owner March 7, 2023 19:15
@jeffdaley jeffdaley merged commit 1a968d4 into main Mar 25, 2023
@jeffdaley jeffdaley deleted the jeffdaley/doc-tile-thumbnail branch March 25, 2023 00:39
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
* Start of Doc::Thumbnail

* Adjust folder appearance

* Design tweaks

* SVG tweaks

* Revised design

* Cleanup

* Add tests

* Obsolete product-badge tweak

* Adjust border radius

* Extend rather than replace shadows

* Tweak small thumbnail

* Post-merge style tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants