Use {{auto-height-textarea}} modifier on sidebar
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
changed the title
{{auto-height-textarea}} modifier on sidebar
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Install `ember-modifier` * `auto-height-textarea` modifier * Write tests * Apply modifier to customEditableField * Cleanup * Handle delete case * Adjust overflow, apply to title and summary * Update yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
auto-height-textareamodifier and applies it to the sidebar inputs.Our current textareas are a hard-coded 4 rows tall. This is overkill for something like "Target version":
On the other hand, summaries longer than a sentence get cut off:
The new inputs grow (or shrink) according to their content:
with the title and summary fields having a min-height: