Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Subscribed" and "Removed" messages to switches; Fix broken tests #7

Merged
merged 7 commits into from
Feb 8, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Feb 1, 2023

Confirms user actions by adding a temporary confirmation message onClick.
In addition, fixes tests that broke when we switched from mock data to database-stored information.

CleanShot.2023-01-31.at.21.03.10.mp4

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 1, 2023

CLA assistant check
All committers have signed the CLA.

@jeffdaley jeffdaley force-pushed the jeffdaley/subscribe-unsubscribe-feedback branch from 66af3d2 to b024464 Compare February 1, 2023 02:07
@jeffdaley jeffdaley changed the title Add transient "Subscribed" and "Removed" messages to subscription switches Add "Subscribed" and "Removed" messages to switches; Fix broken tests Feb 3, 2023
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeffdaley jeffdaley merged commit c5c5719 into main Feb 8, 2023
@jeffdaley jeffdaley deleted the jeffdaley/subscribe-unsubscribe-feedback branch February 8, 2023 18:25
anuragprafulla referenced this pull request in razorpay/hermes Jun 27, 2023
…cribe-feedback

Add "Subscribed" and "Removed" messages to switches; Fix broken tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants