Sidebar: Show CustomField data to non-owners #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Feb 28, 2023
| @onChange={{perform this.save field}} | ||
| @updateFieldValue={{this.updateCustomFieldValue}} | ||
| @loading={{this.save.isRunning}} | ||
| @disabled={{or this.editingIsDisabled (not this.isOwner)}} |
There was a problem hiding this comment.
Non-owners get the read-only @disabled version of the field.
jeffdaley
commented
Feb 28, 2023
| @@ -319,17 +319,15 @@ | |||
| <small class="hds-typography-body-100 hds-foreground-faint"> | |||
| {{attributes.displayName}} | |||
| </small> | |||
| {{#if this.isOwner}} | |||
There was a problem hiding this comment.
We move this check to the @disabled argument.
jfreda
approved these changes
Feb 28, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
Show customEditableField data to non-owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a template-logic bug where non-owners weren't seeing customEditableField data.