Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where updating the review status of a document with custom fi… #66

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jfreda
Copy link
Contributor

@jfreda jfreda commented Feb 28, 2023

…elds can error

This bug could cause the indexer to fail in certain cases.

@jfreda jfreda requested a review from a team as a code owner February 28, 2023 20:15
return db.
Model(&d).
Omit(clause.Associations).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gorm associations magic was the main culprit for the bug.

@jfreda jfreda merged commit 99356cb into main Mar 1, 2023
@jfreda jfreda deleted the jfreda/fix-update-review-custom-field-bug branch March 1, 2023 00:11
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
hashicorp-forge#66)

Fix bug where updating the review status of a document with custom fields can error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants