Fix docs and facets on /my route
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
referenced
this pull request
Feb 27, 2023
* Merge Facet types * Convert toolbar to TS * Add Toolbar types * Documentation * Add tests * Cleanup * Renames, docs, cleanup * Refactor `handleClick` * Toolbar Service with working filters on all routes * Working LinkTo filters * Design tags * Route-based filters * Improve dropdown closing and model loading * Tests, cleanup and rearranging * Move styles to SCSS; Documentation; Cleanup * Test `get-facet-query-hash` * Refactor route promises
jfreda
approved these changes
Feb 27, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
Update my.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a missing
isOwnerargument to the My Docsmodel()that I mistakenly didn't carry over when doing #37. Without this, My Docs is just the same as All Docs. Apologies!