Add "leave approver role" function; clean up sidebar approval controls #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffdaley
commented
Feb 8, 2024
•
jeffdaley
commented
- Adds the ability for approvers to remove themselves from the approver role
- Adds tests for sidebar-footer-related functions
- Adds tooltips to the icon-only controls ("Delete...", "Reject")
- Refactors the footer to improve semantics and template readability
jeffdaley
force-pushed
the
jeffdaley/approval-buttons
branch
from
d0ad2b2
to
4731241
Compare
jeffdaley
commented
Feb 8, 2024
Comment on lines
-642
to
-663
| /** | ||
| * Used when approving a document. | ||
| * Adds the user's email to the `approvedBy` array. | ||
| */ | ||
| this.post("/approvals/:document_id", (schema, request) => { | ||
| const document = schema.document.findBy({ | ||
| objectID: request.params.document_id, | ||
| }); | ||
|
|
||
| if (document) { | ||
| if (!document.attrs.approvedBy?.includes(TEST_USER_EMAIL)) { | ||
| const approvedBy = document.attrs.approvedBy || []; | ||
| document.update({ | ||
| approvedBy: [...approvedBy, TEST_USER_EMAIL], | ||
| }); | ||
| } | ||
| return new Response(200, {}, document.attrs); | ||
| } | ||
|
|
||
| return new Response(404, {}, {}); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Not deleted, just moved up.
jeffdaley
changed the title
jfreda
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.