Scrollable FacetDropdowns with keyboard support #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffdaley
commented
Feb 16, 2023
•
jeffdaley
commented
- Allows FacetDropdowns to display all filters instead of just the first 10
- Includes a type-to-filter function for long lists, along with a scrollable overflow container
- Improves keyboard-navigation
- Adds documentation and tests
jeffdaley
force-pushed
the
jeffdaley/facet-overflow
branch
from
d88877c
to
1ce7b24
Compare
jeffdaley
force-pushed
the
jeffdaley/facet-overflow
branch
from
3a91fcd
to
d76c732
Compare
jeffdaley
force-pushed
the
jeffdaley/facet-overflow
branch
from
d76c732
to
54b3c73
Compare
jeffdaley
changed the title
jeffdaley
force-pushed
the
jeffdaley/facet-overflow
branch
3 times, most recently
from
4134d21
to
f1c0b7a
Compare
jeffdaley
force-pushed
the
jeffdaley/facet-overflow
branch
from
f1c0b7a
to
8508ec6
Compare
jeffdaley
changed the title
jeffdaley
force-pushed
the
jeffdaley/facet-overflow
branch
from
b38ca51
to
7c46881
Compare
jfreda
approved these changes
Mar 10, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Prototype of Facet overflow * Listbox functions and design tweaks * Dismiss on focus/clickout; Search resets * Dismissibility * Improve documentation * Add and update tests * Component breakup; aria-activedescendant * Improved keyboard functions * Improve ID assignment and mouse interaction * Add tests; Improve aria-roles * Add ListItem tests * Dismissible tests * Renaming and cleanup * Remove `autofocus` modifier * Remove element assignment * Improve maybeScrollIntoView * Move functions to parent component, update tests * Fix failing tests * Make filters clickable * Fix tests; Cleanup * Short-term sortBy fix * Add SortBy support and fix tests * Documentation and cleanup * Add ARIA references * More list-item tests; Add Sinon * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.